Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std_meson_args: add release buildtype #8000

Merged
merged 1 commit into from
Jul 14, 2020
Merged

std_meson_args: add release buildtype #8000

merged 1 commit into from
Jul 14, 2020

Conversation

tschoonj
Copy link
Contributor

By default meson compiles using the debug buildtype, which corresponds
to -O0 -g. The release buildtype changes this to -O3.

Not sure how useful this is as Homebrew's superenv changes these flags
anyway, but something similar is done for CMake, so thought it would be ok to do the same thing for meson.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Bo98
Copy link
Member

Bo98 commented Jul 14, 2020 •
edited
Loading

Makes sense to me. Can you drop the Gemfile.lock changes from this pull request?

Not sure how useful this is as Homebrew's superenv changes these flags anyway

Homebrew indeed filters out -O[0-9zs] and -g flags. By default Homebrew uses -Os on macOS and -O2 on Linux, unless overridden by calls like ENV.O3 (see the awk formula).

something similar is done for CMake, so thought it would be ok to do the same thing for meson.

Agreed. It may also have some effect on some build scripts that check get_option('buildtype'). I know some of the GNOME software do this.

@tschoonj
std_meson_args: add release buildtype
678dbc1 
By default meson compiles using the debug buildtype, which corresponds
to -O0 -g. The release buildtype changes this to -O3.
@tschoonj tschoonj force-pushed the std_meson_args-fix branch from f1a2c17 to 678dbc1 Compare July 14, 2020 10:28
@tschoonj
Copy link
Contributor Author

Many thanks @Bo98 !

I got rid of the Gemfile.lock change that snuck in without me noticing.

@Bo98
Copy link
Member

Bo98 commented Jul 14, 2020

Yeah I think HOMEBREW_DEVELOPER messes with Gemfile.lock at the moment. There's some discussion about it in #7996.

@jonchang
Copy link
Contributor

Congrats on pull request 8000!

@Bo98 Bo98 merged commit f586bf2 into Homebrew:master Jul 14, 2020
@Bo98
Copy link
Member

Bo98 commented Jul 14, 2020

🚀

This was referenced Jul 23, 2020
Closed
Merged
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 24, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tschoonj @Bo98 @jonchang @BrewTestBot